37 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			37 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
From a7323378dcf1f10a98f47b744e6f65e6fd671d84 Mon Sep 17 00:00:00 2001
 | 
						|
From: Ian Molton <ian@mnementh.co.uk>
 | 
						|
Date: Fri, 8 Dec 2017 13:10:28 +0100
 | 
						|
Subject: [PATCH] brcmfmac: Clarify if using braces.
 | 
						|
 | 
						|
Whilst this if () statement is technically correct, it lacks clarity.
 | 
						|
 | 
						|
Signed-off-by: Ian Molton <ian@mnementh.co.uk>
 | 
						|
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
 | 
						|
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
 | 
						|
---
 | 
						|
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 5 +++--
 | 
						|
 1 file changed, 3 insertions(+), 2 deletions(-)
 | 
						|
 | 
						|
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
 | 
						|
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
 | 
						|
@@ -746,16 +746,17 @@ int brcmf_sdiod_send_pkt(struct brcmf_sd
 | 
						|
 	if (err)
 | 
						|
 		return err;
 | 
						|
 
 | 
						|
-	if (pktq->qlen == 1 || !sdiodev->sg_support)
 | 
						|
+	if (pktq->qlen == 1 || !sdiodev->sg_support) {
 | 
						|
 		skb_queue_walk(pktq, skb) {
 | 
						|
 			err = brcmf_sdiod_buff_write(sdiodev, SDIO_FUNC_2,
 | 
						|
 						     addr, skb);
 | 
						|
 			if (err)
 | 
						|
 				break;
 | 
						|
 		}
 | 
						|
-	else
 | 
						|
+	} else {
 | 
						|
 		err = brcmf_sdiod_sglist_rw(sdiodev, SDIO_FUNC_2, true, addr,
 | 
						|
 					    pktq);
 | 
						|
+	}
 | 
						|
 
 | 
						|
 	return err;
 | 
						|
 }
 |