treewide: fix upgrade led handling

The upgrade led is only used if a running led is defined. If no running
led is defined, the upgrade led is ignored and upgrade isn't indicated
at all.

Instead, turn off the running led prior to turning the upgrade led on.
In most cases there isn't any visual change, but it allows to use an
independent led for upgrade indication.

Signed-off-by: Mathias Kresin <dev@kresin.me>

target/linux/apm821xx/base-files/etc/diag.sh

@@ -29,9 +29,11 @@ set_state() {
 		;;
 	upgrade)
 		[ -n "$running" ] && {
-			status_led="$upgrade"
+			status_led="$running"
-			status_led_blink_preinit_regular
+			status_led_off
 		}
+		status_led="$upgrade"
+		status_led_blink_preinit_regular
 		;;
 	done)
 		status_led_off

target/linux/ath79/base-files/etc/diag.sh

@@ -32,9 +32,11 @@ set_state() {
 		;;
 	upgrade)
 		[ -n "$running" ] && {
-			status_led="$upgrade"
+			status_led="$running"
-			status_led_blink_preinit_regular
+			status_led_off
 		}
+		status_led="$upgrade"
+		status_led_blink_preinit_regular
 		;;
 	done)
 		status_led_off

target/linux/ipq40xx/base-files/etc/diag.sh

@@ -32,9 +32,11 @@ set_state() {
 		;;
 	upgrade)
 		[ -n "$running" ] && {
-			status_led="$upgrade"
+			status_led="$running"
-			status_led_blink_preinit_regular
+			status_led_off
 		}
+		status_led="$upgrade"
+		status_led_blink_preinit_regular
 		;;
 	done)
 		status_led_off

target/linux/ipq806x/base-files/etc/diag.sh

@@ -29,9 +29,11 @@ set_state() {
 		;;
 	upgrade)
 		[ -n "$running" ] && {
-			status_led="$upgrade"
+			status_led="$running"
-			status_led_blink_preinit_regular
+			status_led_off
 		}
+		status_led="$upgrade"
+		status_led_blink_preinit_regular
 		;;
 	done)
 		status_led_off