mirror of
				git://git.openwrt.org/openwrt/openwrt.git
				synced 2025-11-04 06:54:27 -05:00 
			
		
		
		
	Build system: x86_64 Build-tested: bcm2708, bcm2709, bcm2710, bcm2711 Run-tested: bcm2708/RPiB+, bcm2709/RPi3B, bcm2710/RPi3B, bcm2711/RPi4B Signed-off-by: Marty Jones <mj8263788@gmail.com> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
		
			
				
	
	
		
			30 lines
		
	
	
		
			1003 B
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			30 lines
		
	
	
		
			1003 B
		
	
	
	
		
			Diff
		
	
	
	
	
	
From f8740e21bb2a6eb11da683901e22fbb6fea80dc8 Mon Sep 17 00:00:00 2001
 | 
						|
From: Maxime Ripard <maxime@cerno.tech>
 | 
						|
Date: Tue, 5 Apr 2022 15:20:27 +0200
 | 
						|
Subject: [PATCH] clk: Test the clock pointer in clk_hw_get_name()
 | 
						|
 | 
						|
Unlike __clk_get_name(), clk_hw_get_name() doesn't test wether passed
 | 
						|
clk_hw pointer is NULL or not and dereferences it directly. This can
 | 
						|
then lead to NULL pointer dereference.
 | 
						|
 | 
						|
Let's make sure the pointer isn't NULL before dereferencing it.
 | 
						|
 | 
						|
Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> # imx8mp
 | 
						|
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> # exynos4210, meson g12b
 | 
						|
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
 | 
						|
---
 | 
						|
 drivers/clk/clk.c | 2 +-
 | 
						|
 1 file changed, 1 insertion(+), 1 deletion(-)
 | 
						|
 | 
						|
--- a/drivers/clk/clk.c
 | 
						|
+++ b/drivers/clk/clk.c
 | 
						|
@@ -269,7 +269,7 @@ EXPORT_SYMBOL_GPL(__clk_get_name);
 | 
						|
 
 | 
						|
 const char *clk_hw_get_name(const struct clk_hw *hw)
 | 
						|
 {
 | 
						|
-	return hw->core->name;
 | 
						|
+	return !hw ? NULL : hw->core->name;
 | 
						|
 }
 | 
						|
 EXPORT_SYMBOL_GPL(clk_hw_get_name);
 | 
						|
 
 |