mirror of
				git://git.openwrt.org/openwrt/openwrt.git
				synced 2025-11-03 14:34:27 -05:00 
			
		
		
		
	* use interface mode switching only when operating in C45 mode Linux prevents switching the interface mode when using C22 MDIO, hence use rate-adapter mode in case the PHY controlled via C22. * use phy_read_paged where appropriate * use existing generic inline functions to handle 10GbE advertisements instead of redundantly defining register macros in realtek.c which are not actually vendor-specific. * make sure 10GbE advertisement is valid, preventing false-positive warning "Downshift occurred from negotiated speed 2.5Gbps to actual speed 1Gbps, check cabling!" with some link-partners using 1G mode. * Support Link Down Power Saving Mode (ALDPS) Signed-off-by: Daniel Golle <daniel@makrotopia.org>
		
			
				
	
	
		
			29 lines
		
	
	
		
			886 B
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			29 lines
		
	
	
		
			886 B
		
	
	
	
		
			Diff
		
	
	
	
	
	
From 929bb4d3cfbc7878326c0771a01a636d49c54b40 Mon Sep 17 00:00:00 2001
 | 
						|
From: Daniel Golle <daniel@makrotopia.org>
 | 
						|
Date: Sat, 22 Apr 2023 01:25:39 +0100
 | 
						|
Subject: [PATCH 3/3] net: phy: realtek: check validity of 10GbE link-partner
 | 
						|
 advertisement
 | 
						|
 | 
						|
Only use link-partner advertisement bits for 10GbE modes if they are
 | 
						|
actually valid. Check LOCALOK and REMOTEOK bits and clear 10GbE modes
 | 
						|
unless both of them are set.
 | 
						|
 | 
						|
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
 | 
						|
---
 | 
						|
 drivers/net/phy/realtek.c | 4 ++++
 | 
						|
 1 file changed, 4 insertions(+)
 | 
						|
 | 
						|
--- a/drivers/net/phy/realtek.c
 | 
						|
+++ b/drivers/net/phy/realtek.c
 | 
						|
@@ -698,6 +698,10 @@ static int rtl822x_read_status(struct ph
 | 
						|
 		if (lpadv < 0)
 | 
						|
 			return lpadv;
 | 
						|
 
 | 
						|
+		if (!(lpadv & MDIO_AN_10GBT_STAT_REMOK) ||
 | 
						|
+		    !(lpadv & MDIO_AN_10GBT_STAT_LOCOK))
 | 
						|
+			lpadv = 0;
 | 
						|
+
 | 
						|
 		mii_10gbt_stat_mod_linkmode_lpa_t(phydev->lp_advertising, lpadv);
 | 
						|
 	}
 | 
						|
 
 |