mirror of
				git://git.openwrt.org/openwrt/openwrt.git
				synced 2025-10-30 21:44:27 -04:00 
			
		
		
		
	
		
			
				
	
	
		
			45 lines
		
	
	
		
			1.6 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			45 lines
		
	
	
		
			1.6 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
| From 98feaf97bc64fc640a6c5b1394cd18fc7cd7dac8 Mon Sep 17 00:00:00 2001
 | |
| From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali@kernel.org>
 | |
| Date: Sun, 28 Mar 2021 14:34:49 +0200
 | |
| Subject: [PATCH] PCI: aardvark: Refactor unmasking summary MSI interrupt
 | |
| MIME-Version: 1.0
 | |
| Content-Type: text/plain; charset=UTF-8
 | |
| Content-Transfer-Encoding: 8bit
 | |
| 
 | |
| Refactor the masking of ISR0/1 Sources and unmasking of summary MSI interrupt
 | |
| so that it corresponds to the comments:
 | |
| - first mask all ISR0/1
 | |
| - then unmask all MSIs
 | |
| - then unmask summary MSI interrupt
 | |
| 
 | |
| Signed-off-by: Pali Rohár <pali@kernel.org>
 | |
| Signed-off-by: Marek Behún <kabel@kernel.org>
 | |
| ---
 | |
|  drivers/pci/controller/pci-aardvark.c | 10 ++++++----
 | |
|  1 file changed, 6 insertions(+), 4 deletions(-)
 | |
| 
 | |
| --- a/drivers/pci/controller/pci-aardvark.c
 | |
| +++ b/drivers/pci/controller/pci-aardvark.c
 | |
| @@ -578,15 +578,17 @@ static void advk_pcie_setup_hw(struct ad
 | |
|  	advk_writel(pcie, PCIE_IRQ_ALL_MASK, HOST_CTRL_INT_STATUS_REG);
 | |
|  
 | |
|  	/* Disable All ISR0/1 Sources */
 | |
| -	reg = PCIE_ISR0_ALL_MASK;
 | |
| -	reg &= ~PCIE_ISR0_MSI_INT_PENDING;
 | |
| -	advk_writel(pcie, reg, PCIE_ISR0_MASK_REG);
 | |
| -
 | |
| +	advk_writel(pcie, PCIE_ISR0_ALL_MASK, PCIE_ISR0_MASK_REG);
 | |
|  	advk_writel(pcie, PCIE_ISR1_ALL_MASK, PCIE_ISR1_MASK_REG);
 | |
|  
 | |
|  	/* Unmask all MSIs */
 | |
|  	advk_writel(pcie, ~(u32)PCIE_MSI_ALL_MASK, PCIE_MSI_MASK_REG);
 | |
|  
 | |
| +	/* Unmask summary MSI interrupt */
 | |
| +	reg = advk_readl(pcie, PCIE_ISR0_MASK_REG);
 | |
| +	reg &= ~PCIE_ISR0_MSI_INT_PENDING;
 | |
| +	advk_writel(pcie, reg, PCIE_ISR0_MASK_REG);
 | |
| +
 | |
|  	/* Enable summary interrupt for GIC SPI source */
 | |
|  	reg = PCIE_IRQ_ALL_MASK & (~PCIE_IRQ_ENABLE_INTS_MASK);
 | |
|  	advk_writel(pcie, reg, HOST_CTRL_INT_MASK_REG);
 |