mirror of
				git://git.openwrt.org/openwrt/openwrt.git
				synced 2025-11-03 22:44:27 -05:00 
			
		
		
		
	
		
			
				
	
	
		
			27 lines
		
	
	
		
			914 B
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			27 lines
		
	
	
		
			914 B
		
	
	
	
		
			Diff
		
	
	
	
	
	
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
 | 
						|
Date: Sun, 12 Feb 2023 07:51:51 +0100
 | 
						|
Subject: [PATCH] net: ethernet: mtk_wed: No need to clear memory after a
 | 
						|
 dma_alloc_coherent() call
 | 
						|
 | 
						|
dma_alloc_coherent() already clears the allocated memory, there is no need
 | 
						|
to explicitly call memset().
 | 
						|
 | 
						|
Moreover, it is likely that the size in the memset() is incorrect and
 | 
						|
should be "size * sizeof(*ring->desc)".
 | 
						|
 | 
						|
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
 | 
						|
Link: https://lore.kernel.org/r/d5acce7dd108887832c9719f62c7201b4c83b3fb.1676184599.git.christophe.jaillet@wanadoo.fr
 | 
						|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
 | 
						|
---
 | 
						|
 | 
						|
--- a/drivers/net/ethernet/mediatek/mtk_wed.c
 | 
						|
+++ b/drivers/net/ethernet/mediatek/mtk_wed.c
 | 
						|
@@ -779,7 +779,6 @@ mtk_wed_rro_ring_alloc(struct mtk_wed_de
 | 
						|
 
 | 
						|
 	ring->desc_size = sizeof(*ring->desc);
 | 
						|
 	ring->size = size;
 | 
						|
-	memset(ring->desc, 0, size);
 | 
						|
 
 | 
						|
 	return 0;
 | 
						|
 }
 |