mirror of
				git://git.openwrt.org/openwrt/openwrt.git
				synced 2025-11-03 22:44:27 -05:00 
			
		
		
		
	This is a pure rename without any changes. It makes maintaining bgmac simpler and will hopefully make adding new kernel a bit easier. Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
		
			
				
	
	
		
			29 lines
		
	
	
		
			956 B
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			29 lines
		
	
	
		
			956 B
		
	
	
	
		
			Diff
		
	
	
	
	
	
From f1640c3ddeec12804bc9a21feee85fc15aca95f6 Mon Sep 17 00:00:00 2001
 | 
						|
From: wangweidong <wangweidong1@huawei.com>
 | 
						|
Date: Wed, 13 Jan 2016 11:06:41 +0800
 | 
						|
Subject: [PATCH] bgmac: fix a missing check for build_skb
 | 
						|
 | 
						|
when build_skb failed, it may occure a NULL pointer.
 | 
						|
So add a 'NULL check' for it.
 | 
						|
 | 
						|
Signed-off-by: Weidong Wang <wangweidong1@huawei.com>
 | 
						|
Signed-off-by: David S. Miller <davem@davemloft.net>
 | 
						|
---
 | 
						|
 drivers/net/ethernet/broadcom/bgmac.c | 5 +++++
 | 
						|
 1 file changed, 5 insertions(+)
 | 
						|
 | 
						|
--- a/drivers/net/ethernet/broadcom/bgmac.c
 | 
						|
+++ b/drivers/net/ethernet/broadcom/bgmac.c
 | 
						|
@@ -469,6 +469,11 @@ static int bgmac_dma_rx_read(struct bgma
 | 
						|
 			len -= ETH_FCS_LEN;
 | 
						|
 
 | 
						|
 			skb = build_skb(buf, BGMAC_RX_ALLOC_SIZE);
 | 
						|
+			if (unlikely(skb)) {
 | 
						|
+				bgmac_err(bgmac, "build_skb failed\n");
 | 
						|
+				put_page(virt_to_head_page(buf));
 | 
						|
+				break;
 | 
						|
+			}
 | 
						|
 			skb_put(skb, BGMAC_RX_FRAME_OFFSET +
 | 
						|
 				BGMAC_RX_BUF_OFFSET + len);
 | 
						|
 			skb_pull(skb, BGMAC_RX_FRAME_OFFSET +
 |