mirror of
				git://git.openwrt.org/openwrt/openwrt.git
				synced 2025-11-03 22:44:27 -05:00 
			
		
		
		
	kernel lock debugging unveiled that we should not call of_reset_control_get inside a clock's enable operation (see below) move of_reset_control_* previously used in pllb_clk_enable to new pllb_clk_prepare and pllb_clk_unprepare functions. use a container to carry runtime information. ------------[ cut here ]------------ WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2742 lockdep_trace_alloc+0xb8/0xfc() DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.14.26 #6 [<c001a6ac>] (unwind_backtrace) from [<c0016dec>] (show_stack+0x10/0x14) [<c0016dec>] (show_stack) from [<c0194f68>] (dump_stack+0x7c/0x94) [<c0194f68>] (dump_stack) from [<c0021b50>] (warn_slowpath_common+0x68/0x8c) [<c0021b50>] (warn_slowpath_common) from [<c0021ba4>] (warn_slowpath_fmt+0x30/0x40) [<c0021ba4>] (warn_slowpath_fmt) from [<c0061b30>] (lockdep_trace_alloc+0xb8/0xfc) [<c0061b30>] (lockdep_trace_alloc) from [<c00cb740>] (kmem_cache_alloc+0x1c/0xf8) [<c00cb740>] (kmem_cache_alloc) from [<c01d33c8>] (of_reset_control_get+0xe8/0x12c) [<c01d33c8>] (of_reset_control_get) from [<c0269228>] (pllb_clk_enable+0x14/0xbc) [<c0269228>] (pllb_clk_enable) from [<c0265738>] (__clk_enable+0x54/0xa0) [<c0265738>] (__clk_enable) from [<c0265acc>] (clk_enable+0x18/0x2c) [<c0265acc>] (clk_enable) from [<c04325f8>] (oxnas_pcie_probe+0x3b8/0x6a0) [<c04325f8>] (oxnas_pcie_probe) from [<c01f2510>] (platform_drv_probe+0x18/0x48) [<c01f2510>] (platform_drv_probe) from [<c01f1070>] (driver_probe_device+0xd8/0x24c) [<c01f1070>] (driver_probe_device) from [<c01f1298>] (__driver_attach+0x70/0x94) [<c01f1298>] (__driver_attach) from [<c01ef728>] (bus_for_each_dev+0x4c/0x98) [<c01ef728>] (bus_for_each_dev) from [<c01f0818>] (bus_add_driver+0xcc/0x1e8) [<c01f0818>] (bus_add_driver) from [<c01f169c>] (driver_register+0xa0/0xe8) [<c01f169c>] (driver_register) from [<c01f2568>] (platform_driver_probe+0x20/0xa4) [<c01f2568>] (platform_driver_probe) from [<c0013a3c>] (do_one_initcall+0x90/0x140) [<c0013a3c>] (do_one_initcall) from [<c0421d38>] (kernel_init_freeable+0x1e4/0x2c0) [<c0421d38>] (kernel_init_freeable) from [<c000c214>] (kernel_init+0x8/0x104) [<c000c214>] (kernel_init) from [<c0008768>] (ret_from_fork+0x14/0x2c) ---[ end trace 5f17ed2f61e0683f ]--- Signed-off-by: Daniel Golle <daniel@makrotopia.org> SVN-Revision: 43787
		
			
				
	
	
		
			298 lines
		
	
	
		
			6.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			298 lines
		
	
	
		
			6.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Copyright (C) 2010 Broadcom
 | 
						|
 * Copyright (C) 2012 Stephen Warren
 | 
						|
 *
 | 
						|
 * This program is free software; you can redistribute it and/or modify it
 | 
						|
 * under the terms and conditions of the GNU General Public License,
 | 
						|
 * version 2, as published by the Free Software Foundation.
 | 
						|
 *
 | 
						|
 * This program is distributed in the hope it will be useful, but WITHOUT
 | 
						|
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 | 
						|
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 | 
						|
 * more details.
 | 
						|
 *
 | 
						|
 * You should have received a copy of the GNU General Public License
 | 
						|
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 | 
						|
 */
 | 
						|
 | 
						|
#include <linux/clk-provider.h>
 | 
						|
#include <linux/clkdev.h>
 | 
						|
#include <linux/clk-provider.h>
 | 
						|
#include <linux/of.h>
 | 
						|
#include <linux/delay.h>
 | 
						|
#include <linux/stringify.h>
 | 
						|
#include <linux/reset.h>
 | 
						|
#include <linux/io.h>
 | 
						|
#include <mach/hardware.h>
 | 
						|
#include <mach/utils.h>
 | 
						|
 | 
						|
#define MHZ (1000 * 1000)
 | 
						|
 | 
						|
struct clk_oxnas_pllb {
 | 
						|
	struct clk_hw hw;
 | 
						|
	struct device_node *devnode;
 | 
						|
	struct reset_control *rstc;
 | 
						|
};
 | 
						|
 | 
						|
#define to_clk_oxnas_pllb(_hw) container_of(_hw, struct clk_oxnas_pllb, hw)
 | 
						|
 | 
						|
static unsigned long plla_clk_recalc_rate(struct clk_hw *hw,
 | 
						|
	unsigned long parent_rate)
 | 
						|
{
 | 
						|
	unsigned long fin = parent_rate;
 | 
						|
	unsigned long pll0;
 | 
						|
	unsigned long fbdiv, refdiv, outdiv;
 | 
						|
 | 
						|
	pll0 = readl_relaxed(SYS_CTRL_PLLA_CTRL0);
 | 
						|
	refdiv = (pll0 >> PLLA_REFDIV_SHIFT) & PLLA_REFDIV_MASK;
 | 
						|
	refdiv += 1;
 | 
						|
	outdiv = (pll0 >> PLLA_OUTDIV_SHIFT) & PLLA_OUTDIV_MASK;
 | 
						|
	outdiv += 1;
 | 
						|
	fbdiv = readl_relaxed(SYS_CTRL_PLLA_CTRL1);
 | 
						|
 | 
						|
	/* seems we will not be here when pll is bypassed, so ignore this
 | 
						|
	 * case */
 | 
						|
 | 
						|
	return fin / MHZ * fbdiv / (refdiv * outdiv) / 32768 * MHZ;
 | 
						|
}
 | 
						|
 | 
						|
static const char *pll_clk_parents[] = {
 | 
						|
	"oscillator",
 | 
						|
};
 | 
						|
 | 
						|
static struct clk_ops plla_ops = {
 | 
						|
	.recalc_rate = plla_clk_recalc_rate,
 | 
						|
};
 | 
						|
 | 
						|
static struct clk_init_data clk_plla_init = {
 | 
						|
	.name = "plla",
 | 
						|
	.ops = &plla_ops,
 | 
						|
	.parent_names = pll_clk_parents,
 | 
						|
	.num_parents = ARRAY_SIZE(pll_clk_parents),
 | 
						|
};
 | 
						|
 | 
						|
static struct clk_hw plla_hw = {
 | 
						|
	.init = &clk_plla_init,
 | 
						|
};
 | 
						|
 | 
						|
static int pllb_clk_is_prepared(struct clk_hw *hw)
 | 
						|
{
 | 
						|
	struct clk_oxnas_pllb *pllb = to_clk_oxnas_pllb(hw);
 | 
						|
 | 
						|
	return !!pllb->rstc;
 | 
						|
}
 | 
						|
 | 
						|
static int pllb_clk_prepare(struct clk_hw *hw)
 | 
						|
{
 | 
						|
	struct clk_oxnas_pllb *pllb = to_clk_oxnas_pllb(hw);
 | 
						|
 | 
						|
	pllb->rstc = of_reset_control_get(pllb->devnode, NULL);
 | 
						|
 | 
						|
	return IS_ERR(pllb->rstc) ? PTR_ERR(pllb->rstc) : 0;
 | 
						|
}
 | 
						|
 | 
						|
static void pllb_clk_unprepare(struct clk_hw *hw)
 | 
						|
{
 | 
						|
	struct clk_oxnas_pllb *pllb = to_clk_oxnas_pllb(hw);
 | 
						|
 | 
						|
	BUG_ON(IS_ERR(pllb->rstc));
 | 
						|
 | 
						|
	reset_control_put(pllb->rstc);
 | 
						|
	pllb->rstc = NULL;
 | 
						|
}
 | 
						|
 | 
						|
static int pllb_clk_enable(struct clk_hw *hw)
 | 
						|
{
 | 
						|
	struct clk_oxnas_pllb *pllb = to_clk_oxnas_pllb(hw);
 | 
						|
 | 
						|
	BUG_ON(IS_ERR(pllb->rstc));
 | 
						|
 | 
						|
	/* put PLL into bypass */
 | 
						|
	oxnas_register_set_mask(SEC_CTRL_PLLB_CTRL0, BIT(PLLB_BYPASS));
 | 
						|
	wmb();
 | 
						|
	udelay(10);
 | 
						|
	reset_control_assert(pllb->rstc);
 | 
						|
	udelay(10);
 | 
						|
	/* set PLL B control information */
 | 
						|
	writel((1 << PLLB_ENSAT) | (1 << PLLB_OUTDIV) | (2 << PLLB_REFDIV),
 | 
						|
				SEC_CTRL_PLLB_CTRL0);
 | 
						|
	reset_control_deassert(pllb->rstc);
 | 
						|
	udelay(100);
 | 
						|
	oxnas_register_clear_mask(SEC_CTRL_PLLB_CTRL0, BIT(PLLB_BYPASS));
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static void pllb_clk_disable(struct clk_hw *hw)
 | 
						|
{
 | 
						|
	struct clk_oxnas_pllb *pllb = to_clk_oxnas_pllb(hw);
 | 
						|
 | 
						|
	BUG_ON(IS_ERR(pllb->rstc));
 | 
						|
 | 
						|
	/* put PLL into bypass */
 | 
						|
	oxnas_register_set_mask(SEC_CTRL_PLLB_CTRL0, BIT(PLLB_BYPASS));
 | 
						|
	wmb();
 | 
						|
	udelay(10);
 | 
						|
 | 
						|
	reset_control_assert(pllb->rstc);
 | 
						|
}
 | 
						|
 | 
						|
static struct clk_ops pllb_ops = {
 | 
						|
	.prepare = pllb_clk_prepare,
 | 
						|
	.unprepare = pllb_clk_unprepare,
 | 
						|
	.is_prepared = pllb_clk_is_prepared,
 | 
						|
	.enable = pllb_clk_enable,
 | 
						|
	.disable = pllb_clk_disable,
 | 
						|
};
 | 
						|
 | 
						|
static struct clk_init_data clk_pllb_init = {
 | 
						|
	.name = "pllb",
 | 
						|
	.ops = &pllb_ops,
 | 
						|
	.parent_names = pll_clk_parents,
 | 
						|
	.num_parents = ARRAY_SIZE(pll_clk_parents),
 | 
						|
};
 | 
						|
 | 
						|
 | 
						|
/* standard gate clock */
 | 
						|
struct clk_std {
 | 
						|
	struct clk_hw hw;
 | 
						|
	signed char bit;
 | 
						|
};
 | 
						|
 | 
						|
#define NUM_STD_CLKS 17
 | 
						|
#define to_stdclk(_hw) container_of(_hw, struct clk_std, hw)
 | 
						|
 | 
						|
static int std_clk_is_enabled(struct clk_hw *hw)
 | 
						|
{
 | 
						|
	struct clk_std *std = to_stdclk(hw);
 | 
						|
 | 
						|
	return readl_relaxed(SYSCTRL_CLK_STAT) & BIT(std->bit);
 | 
						|
}
 | 
						|
 | 
						|
static int std_clk_enable(struct clk_hw *hw)
 | 
						|
{
 | 
						|
	struct clk_std *std = to_stdclk(hw);
 | 
						|
 | 
						|
	writel(BIT(std->bit), SYS_CTRL_CLK_SET_CTRL);
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static void std_clk_disable(struct clk_hw *hw)
 | 
						|
{
 | 
						|
	struct clk_std *std = to_stdclk(hw);
 | 
						|
 | 
						|
	writel(BIT(std->bit), SYS_CTRL_CLK_CLR_CTRL);
 | 
						|
}
 | 
						|
 | 
						|
static struct clk_ops std_clk_ops = {
 | 
						|
	.enable = std_clk_enable,
 | 
						|
	.disable = std_clk_disable,
 | 
						|
	.is_enabled = std_clk_is_enabled,
 | 
						|
};
 | 
						|
 | 
						|
static const char *std_clk_parents[] = {
 | 
						|
	"oscillator",
 | 
						|
};
 | 
						|
 | 
						|
static const char *eth_parents[] = {
 | 
						|
	"gmacclk",
 | 
						|
};
 | 
						|
 | 
						|
#define DECLARE_STD_CLKP(__clk, __bit, __parent)	\
 | 
						|
static struct clk_init_data clk_##__clk##_init = {	\
 | 
						|
	.name = __stringify(__clk),			\
 | 
						|
	.ops = &std_clk_ops,				\
 | 
						|
	.parent_names = __parent,		\
 | 
						|
	.num_parents = ARRAY_SIZE(__parent),	\
 | 
						|
};							\
 | 
						|
							\
 | 
						|
static struct clk_std clk_##__clk = {			\
 | 
						|
	.bit = __bit,					\
 | 
						|
	.hw = {						\
 | 
						|
		.init = &clk_##__clk##_init,		\
 | 
						|
	},						\
 | 
						|
}
 | 
						|
 | 
						|
#define DECLARE_STD_CLK(__clk, __bit) DECLARE_STD_CLKP(__clk, __bit, \
 | 
						|
							std_clk_parents)
 | 
						|
 | 
						|
DECLARE_STD_CLK(leon, 0);
 | 
						|
DECLARE_STD_CLK(dma_sgdma, 1);
 | 
						|
DECLARE_STD_CLK(cipher, 2);
 | 
						|
DECLARE_STD_CLK(sd, 3);
 | 
						|
DECLARE_STD_CLK(sata, 4);
 | 
						|
DECLARE_STD_CLK(audio, 5);
 | 
						|
DECLARE_STD_CLK(usbmph, 6);
 | 
						|
DECLARE_STD_CLKP(etha, 7, eth_parents);
 | 
						|
DECLARE_STD_CLK(pciea, 8);
 | 
						|
DECLARE_STD_CLK(static, 9);
 | 
						|
DECLARE_STD_CLK(ethb, 10);
 | 
						|
DECLARE_STD_CLK(pcieb, 11);
 | 
						|
DECLARE_STD_CLK(ref600, 12);
 | 
						|
DECLARE_STD_CLK(usbdev, 13);
 | 
						|
 | 
						|
struct clk_hw *std_clk_hw_tbl[] = {
 | 
						|
	&clk_leon.hw,
 | 
						|
	&clk_dma_sgdma.hw,
 | 
						|
	&clk_cipher.hw,
 | 
						|
	&clk_sd.hw,
 | 
						|
	&clk_sata.hw,
 | 
						|
	&clk_audio.hw,
 | 
						|
	&clk_usbmph.hw,
 | 
						|
	&clk_etha.hw,
 | 
						|
	&clk_pciea.hw,
 | 
						|
	&clk_static.hw,
 | 
						|
	&clk_ethb.hw,
 | 
						|
	&clk_pcieb.hw,
 | 
						|
	&clk_ref600.hw,
 | 
						|
	&clk_usbdev.hw,
 | 
						|
};
 | 
						|
 | 
						|
struct clk *std_clk_tbl[ARRAY_SIZE(std_clk_hw_tbl)];
 | 
						|
 | 
						|
static struct clk_onecell_data std_clk_data;
 | 
						|
 | 
						|
void __init oxnas_init_stdclk(struct device_node *np)
 | 
						|
{
 | 
						|
	int i;
 | 
						|
 | 
						|
	for (i = 0; i < ARRAY_SIZE(std_clk_hw_tbl); i++) {
 | 
						|
		std_clk_tbl[i] = clk_register(NULL, std_clk_hw_tbl[i]);
 | 
						|
		BUG_ON(IS_ERR(std_clk_tbl[i]));
 | 
						|
	}
 | 
						|
	std_clk_data.clks = std_clk_tbl;
 | 
						|
	std_clk_data.clk_num = ARRAY_SIZE(std_clk_tbl);
 | 
						|
	of_clk_add_provider(np, of_clk_src_onecell_get, &std_clk_data);
 | 
						|
}
 | 
						|
CLK_OF_DECLARE(oxnas_pllstd, "plxtech,nas782x-stdclk", oxnas_init_stdclk);
 | 
						|
 | 
						|
void __init oxnas_init_plla(struct device_node *np)
 | 
						|
{
 | 
						|
	struct clk *clk;
 | 
						|
 | 
						|
	clk = clk_register(NULL, &plla_hw);
 | 
						|
	BUG_ON(IS_ERR(clk));
 | 
						|
	/* mark it as enabled */
 | 
						|
	clk_prepare_enable(clk);
 | 
						|
	of_clk_add_provider(np, of_clk_src_simple_get, clk);
 | 
						|
}
 | 
						|
CLK_OF_DECLARE(oxnas_plla, "plxtech,nas782x-plla", oxnas_init_plla);
 | 
						|
 | 
						|
void __init oxnas_init_pllb(struct device_node *np)
 | 
						|
{
 | 
						|
	struct clk *clk;
 | 
						|
	struct clk_oxnas_pllb *pllb;
 | 
						|
 | 
						|
	pllb = kmalloc(sizeof(*pllb), GFP_KERNEL);
 | 
						|
	BUG_ON(!pllb);
 | 
						|
 | 
						|
	pllb->hw.init = &clk_pllb_init;
 | 
						|
	pllb->devnode = np;
 | 
						|
	pllb->rstc = NULL;
 | 
						|
 | 
						|
	clk = clk_register(NULL, &pllb->hw);
 | 
						|
	BUG_ON(IS_ERR(clk));
 | 
						|
	of_clk_add_provider(np, of_clk_src_simple_get, clk);
 | 
						|
}
 | 
						|
CLK_OF_DECLARE(oxnas_pllb, "plxtech,nas782x-pllb", oxnas_init_pllb);
 |