mirror of
				git://git.openwrt.org/openwrt/openwrt.git
				synced 2025-10-31 14:04:26 -04:00 
			
		
		
		
	In kernel 5.4 -Werror=implicit-fallthrough is treated as error:
arch/mips/bcm63xx/cpu.c: In function 'detect_cpu_clock':
arch/mips/bcm63xx/cpu.c:158:2: error: this statement may fall through [-Werror=implicit-fallthrough=]
  {
  ^
arch/mips/bcm63xx/cpu.c:179:2: note: here
  case BCM6328_CPU_ID:
  ^~~~
cc1: all warnings being treated as errors
This can be fixed by adding "Fall through" as a comment where intended,
and has to be fixed by returning a proper default otherwise.
In case of the default clock frequency for BCM6318 we fixed this by
returning the default value taken from BCM6328 and BCM6362.
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
		
	
			
		
			
				
	
	
		
			52 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
			
		
		
	
	
			52 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			Diff
		
	
	
	
	
	
| --- a/arch/mips/bcm63xx/boards/board_common.c
 | |
| +++ b/arch/mips/bcm63xx/boards/board_common.c
 | |
| @@ -246,7 +246,7 @@ int __init board_register_devices(void)
 | |
|  	/* register any fixups */
 | |
|  	for (i = 0; i < board.has_caldata; i++)
 | |
|  		pci_enable_ath9k_fixup(board.caldata[i].slot, board.caldata[i].caldata_offset,
 | |
| -			board.caldata[i].endian_check);
 | |
| +			board.caldata[i].endian_check, board.caldata[i].led_pin, board.caldata[i].led_active_high);
 | |
|  
 | |
|  	return 0;
 | |
|  }
 | |
| --- a/arch/mips/bcm63xx/pci-ath9k-fixup.c
 | |
| +++ b/arch/mips/bcm63xx/pci-ath9k-fixup.c
 | |
| @@ -184,13 +184,15 @@ static void ath9k_pci_fixup(struct pci_d
 | |
|  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATHEROS, PCI_ANY_ID, ath9k_pci_fixup);
 | |
|  
 | |
|  void __init pci_enable_ath9k_fixup(unsigned slot, u32 offset,
 | |
| -	unsigned endian_check)
 | |
| +	unsigned endian_check, int led_pin, bool led_active_high)
 | |
|  {
 | |
|  	if (ath9k_num_fixups >= ARRAY_SIZE(ath9k_fixups))
 | |
|  		return;
 | |
|  
 | |
|  	ath9k_fixups[ath9k_num_fixups].slot = slot;
 | |
|  	ath9k_fixups[ath9k_num_fixups].pdata.endian_check = endian_check;
 | |
| +	ath9k_fixups[ath9k_num_fixups].pdata.led_pin = led_pin;
 | |
| +	ath9k_fixups[ath9k_num_fixups].pdata.led_active_high = led_active_high;
 | |
|  
 | |
|  	if (!bcm63xx_read_eeprom(ath9k_fixups[ath9k_num_fixups].pdata.eeprom_data, offset))
 | |
|  		return;
 | |
| --- a/arch/mips/include/asm/mach-bcm63xx/board_bcm963xx.h
 | |
| +++ b/arch/mips/include/asm/mach-bcm63xx/board_bcm963xx.h
 | |
| @@ -21,6 +21,8 @@ struct ath9k_caldata {
 | |
|  	unsigned int	slot;
 | |
|  	u32		caldata_offset;
 | |
|  	unsigned int	endian_check:1;
 | |
| +	int		led_pin;
 | |
| +	bool		led_active_high;
 | |
|  };
 | |
|  
 | |
|  /*
 | |
| --- a/arch/mips/include/asm/mach-bcm63xx/pci_ath9k_fixup.h
 | |
| +++ b/arch/mips/include/asm/mach-bcm63xx/pci_ath9k_fixup.h
 | |
| @@ -3,6 +3,6 @@
 | |
|  
 | |
|  
 | |
|  void pci_enable_ath9k_fixup(unsigned slot, u32 offset,
 | |
| -	unsigned endian_check) __init;
 | |
| +	unsigned endian_check, int led_pin, bool led_active_high) __init;
 | |
|  
 | |
|  #endif /* _PCI_ATH9K_FIXUP */
 |