mirror of
				git://git.openwrt.org/openwrt/openwrt.git
				synced 2025-11-03 14:34:27 -05:00 
			
		
		
		
	mac80211: merge the virtual time based airtime scheduler
Improves airtime fairness, especially for devices with larger firmware buffers Signed-off-by: Felix Fietkau <nbd@nbd.name>
This commit is contained in:
		
							parent
							
								
									d1a812c49b
								
							
						
					
					
						commit
						a5888ad6b3
					
				@ -0,0 +1,111 @@
 | 
			
		||||
From: Lorenzo Bianconi <lorenzo@kernel.org>
 | 
			
		||||
Date: Sat, 9 Jan 2021 18:57:51 +0100
 | 
			
		||||
Subject: [PATCH] mac80211: introduce aql_enable node in debugfs
 | 
			
		||||
 | 
			
		||||
Introduce aql_enable node in debugfs in order to enable/disable aql.
 | 
			
		||||
This is useful for debugging purpose.
 | 
			
		||||
 | 
			
		||||
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
 | 
			
		||||
Link: https://lore.kernel.org/r/e7a934d5d84e4796c4f97ea5de4e66c824296b07.1610214851.git.lorenzo@kernel.org
 | 
			
		||||
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
 | 
			
		||||
---
 | 
			
		||||
 | 
			
		||||
--- a/net/mac80211/debugfs.c
 | 
			
		||||
+++ b/net/mac80211/debugfs.c
 | 
			
		||||
@@ -281,6 +281,56 @@ static const struct file_operations aql_
 | 
			
		||||
 	.llseek = default_llseek,
 | 
			
		||||
 };
 | 
			
		||||
 
 | 
			
		||||
+static ssize_t aql_enable_read(struct file *file, char __user *user_buf,
 | 
			
		||||
+			       size_t count, loff_t *ppos)
 | 
			
		||||
+{
 | 
			
		||||
+	char buf[3];
 | 
			
		||||
+	int len;
 | 
			
		||||
+
 | 
			
		||||
+	len = scnprintf(buf, sizeof(buf), "%d\n",
 | 
			
		||||
+			!static_key_false(&aql_disable.key));
 | 
			
		||||
+
 | 
			
		||||
+	return simple_read_from_buffer(user_buf, count, ppos, buf, len);
 | 
			
		||||
+}
 | 
			
		||||
+
 | 
			
		||||
+static ssize_t aql_enable_write(struct file *file, const char __user *user_buf,
 | 
			
		||||
+				size_t count, loff_t *ppos)
 | 
			
		||||
+{
 | 
			
		||||
+	bool aql_disabled = static_key_false(&aql_disable.key);
 | 
			
		||||
+	char buf[3];
 | 
			
		||||
+	size_t len;
 | 
			
		||||
+
 | 
			
		||||
+	if (count > sizeof(buf))
 | 
			
		||||
+		return -EINVAL;
 | 
			
		||||
+
 | 
			
		||||
+	if (copy_from_user(buf, user_buf, count))
 | 
			
		||||
+		return -EFAULT;
 | 
			
		||||
+
 | 
			
		||||
+	buf[sizeof(buf) - 1] = '\0';
 | 
			
		||||
+	len = strlen(buf);
 | 
			
		||||
+	if (len > 0 && buf[len - 1] == '\n')
 | 
			
		||||
+		buf[len - 1] = 0;
 | 
			
		||||
+
 | 
			
		||||
+	if (buf[0] == '0' && buf[1] == '\0') {
 | 
			
		||||
+		if (!aql_disabled)
 | 
			
		||||
+			static_branch_inc(&aql_disable);
 | 
			
		||||
+	} else if (buf[0] == '1' && buf[1] == '\0') {
 | 
			
		||||
+		if (aql_disabled)
 | 
			
		||||
+			static_branch_dec(&aql_disable);
 | 
			
		||||
+	} else {
 | 
			
		||||
+		return -EINVAL;
 | 
			
		||||
+	}
 | 
			
		||||
+
 | 
			
		||||
+	return count;
 | 
			
		||||
+}
 | 
			
		||||
+
 | 
			
		||||
+static const struct file_operations aql_enable_ops = {
 | 
			
		||||
+	.write = aql_enable_write,
 | 
			
		||||
+	.read = aql_enable_read,
 | 
			
		||||
+	.open = simple_open,
 | 
			
		||||
+	.llseek = default_llseek,
 | 
			
		||||
+};
 | 
			
		||||
+
 | 
			
		||||
 static ssize_t force_tx_status_read(struct file *file,
 | 
			
		||||
 				    char __user *user_buf,
 | 
			
		||||
 				    size_t count,
 | 
			
		||||
@@ -569,6 +619,7 @@ void debugfs_hw_add(struct ieee80211_loc
 | 
			
		||||
 	DEBUGFS_ADD(power);
 | 
			
		||||
 	DEBUGFS_ADD(hw_conf);
 | 
			
		||||
 	DEBUGFS_ADD_MODE(force_tx_status, 0600);
 | 
			
		||||
+	DEBUGFS_ADD_MODE(aql_enable, 0600);
 | 
			
		||||
 
 | 
			
		||||
 	if (local->ops->wake_tx_queue)
 | 
			
		||||
 		DEBUGFS_ADD_MODE(aqm, 0600);
 | 
			
		||||
--- a/net/mac80211/ieee80211_i.h
 | 
			
		||||
+++ b/net/mac80211/ieee80211_i.h
 | 
			
		||||
@@ -1140,6 +1140,8 @@ enum mac80211_scan_state {
 | 
			
		||||
 	SCAN_ABORT,
 | 
			
		||||
 };
 | 
			
		||||
 
 | 
			
		||||
+DECLARE_STATIC_KEY_FALSE(aql_disable);
 | 
			
		||||
+
 | 
			
		||||
 struct ieee80211_local {
 | 
			
		||||
 	/* embed the driver visible part.
 | 
			
		||||
 	 * don't cast (use the static inlines below), but we keep
 | 
			
		||||
--- a/net/mac80211/tx.c
 | 
			
		||||
+++ b/net/mac80211/tx.c
 | 
			
		||||
@@ -3887,6 +3887,8 @@ void __ieee80211_schedule_txq(struct iee
 | 
			
		||||
 }
 | 
			
		||||
 EXPORT_SYMBOL(__ieee80211_schedule_txq);
 | 
			
		||||
 
 | 
			
		||||
+DEFINE_STATIC_KEY_FALSE(aql_disable);
 | 
			
		||||
+
 | 
			
		||||
 bool ieee80211_txq_airtime_check(struct ieee80211_hw *hw,
 | 
			
		||||
 				 struct ieee80211_txq *txq)
 | 
			
		||||
 {
 | 
			
		||||
@@ -3896,6 +3898,9 @@ bool ieee80211_txq_airtime_check(struct
 | 
			
		||||
 	if (!wiphy_ext_feature_isset(local->hw.wiphy, NL80211_EXT_FEATURE_AQL))
 | 
			
		||||
 		return true;
 | 
			
		||||
 
 | 
			
		||||
+	if (static_branch_unlikely(&aql_disable))
 | 
			
		||||
+		return true;
 | 
			
		||||
+
 | 
			
		||||
 	if (!txq->sta)
 | 
			
		||||
 		return true;
 | 
			
		||||
 
 | 
			
		||||
@ -0,0 +1,39 @@
 | 
			
		||||
From: Johannes Berg <johannes.berg@intel.com>
 | 
			
		||||
Date: Fri, 18 Jun 2021 13:41:44 +0300
 | 
			
		||||
Subject: [PATCH] mac80211: rearrange struct txq_info for fewer holes
 | 
			
		||||
 | 
			
		||||
We can slightly decrease the size of struct txq_info by
 | 
			
		||||
rearranging some fields for fewer holes, so do that.
 | 
			
		||||
 | 
			
		||||
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
 | 
			
		||||
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
 | 
			
		||||
Link: https://lore.kernel.org/r/iwlwifi.20210618133832.1bf019a1fe2e.Ib54622b8d6dc1a9a7dc484e573c073119450538b@changeid
 | 
			
		||||
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
 | 
			
		||||
---
 | 
			
		||||
 | 
			
		||||
--- a/net/mac80211/ieee80211_i.h
 | 
			
		||||
+++ b/net/mac80211/ieee80211_i.h
 | 
			
		||||
@@ -5,7 +5,7 @@
 | 
			
		||||
  * Copyright 2006-2007	Jiri Benc <jbenc@suse.cz>
 | 
			
		||||
  * Copyright 2007-2010	Johannes Berg <johannes@sipsolutions.net>
 | 
			
		||||
  * Copyright 2013-2015  Intel Mobile Communications GmbH
 | 
			
		||||
- * Copyright (C) 2018-2020 Intel Corporation
 | 
			
		||||
+ * Copyright (C) 2018-2021 Intel Corporation
 | 
			
		||||
  */
 | 
			
		||||
 
 | 
			
		||||
 #ifndef IEEE80211_I_H
 | 
			
		||||
@@ -848,9 +848,12 @@ struct txq_info {
 | 
			
		||||
 	struct fq_tin tin;
 | 
			
		||||
 	struct codel_vars def_cvars;
 | 
			
		||||
 	struct codel_stats cstats;
 | 
			
		||||
-	struct sk_buff_head frags;
 | 
			
		||||
-	struct list_head schedule_order;
 | 
			
		||||
+
 | 
			
		||||
 	u16 schedule_round;
 | 
			
		||||
+	struct list_head schedule_order;
 | 
			
		||||
+
 | 
			
		||||
+	struct sk_buff_head frags;
 | 
			
		||||
+
 | 
			
		||||
 	unsigned long flags;
 | 
			
		||||
 
 | 
			
		||||
 	/* keep last! */
 | 
			
		||||
										
											
												File diff suppressed because it is too large
												Load Diff
											
										
									
								
							@ -57,7 +57,7 @@
 | 
			
		||||
 	__NL80211_ATTR_AFTER_LAST,
 | 
			
		||||
--- a/net/mac80211/cfg.c
 | 
			
		||||
+++ b/net/mac80211/cfg.c
 | 
			
		||||
@@ -2709,6 +2709,19 @@ static int ieee80211_get_tx_power(struct
 | 
			
		||||
@@ -2742,6 +2742,19 @@ static int ieee80211_get_tx_power(struct
 | 
			
		||||
 	return 0;
 | 
			
		||||
 }
 | 
			
		||||
 
 | 
			
		||||
@ -77,7 +77,7 @@
 | 
			
		||||
 static int ieee80211_set_wds_peer(struct wiphy *wiphy, struct net_device *dev,
 | 
			
		||||
 				  const u8 *addr)
 | 
			
		||||
 {
 | 
			
		||||
@@ -4139,6 +4152,7 @@ const struct cfg80211_ops mac80211_confi
 | 
			
		||||
@@ -4172,6 +4185,7 @@ const struct cfg80211_ops mac80211_confi
 | 
			
		||||
 	.set_wiphy_params = ieee80211_set_wiphy_params,
 | 
			
		||||
 	.set_tx_power = ieee80211_set_tx_power,
 | 
			
		||||
 	.get_tx_power = ieee80211_get_tx_power,
 | 
			
		||||
@ -87,7 +87,7 @@
 | 
			
		||||
 	CFG80211_TESTMODE_CMD(ieee80211_testmode_cmd)
 | 
			
		||||
--- a/net/mac80211/ieee80211_i.h
 | 
			
		||||
+++ b/net/mac80211/ieee80211_i.h
 | 
			
		||||
@@ -1390,6 +1390,7 @@ struct ieee80211_local {
 | 
			
		||||
@@ -1426,6 +1426,7 @@ struct ieee80211_local {
 | 
			
		||||
 	int dynamic_ps_forced_timeout;
 | 
			
		||||
 
 | 
			
		||||
 	int user_power_level; /* in dBm, for all interfaces */
 | 
			
		||||
 | 
			
		||||
		Loading…
	
		Reference in New Issue
	
	Block a user