hurricos/openwrt-mirror
1
0
Fork 0
mirror of git://git.openwrt.org/openwrt/openwrt.git synced 2026-01-25 05:01:00 -05:00
Code Issues Projects Releases Wiki Activity

ipq806x: dts: fix SPI chip select GPIO polarity

Browse Source 
The SPI chip select GPIO polarity is active low by default. We must
use "spi-cs-high" dts property to toggle the polarity. The polarity
on "cs-gpios" won't take effect at all[1]. Fix these incorrect GPIO
polarities to silence the kernel warnings.

[1] Refer to Linux/Documentation/devicetree/bindings/spi/spi-controller.yaml
```
      device node     | cs-gpio       | CS pin state active | Note
      ================+===============+=====================+=====
      spi-cs-high     | -             | H                   |
      -               | -             | L                   |
      spi-cs-high     | ACTIVE_HIGH   | H                   |
      -               | ACTIVE_HIGH   | L                   | 1
      spi-cs-high     | ACTIVE_LOW    | H                   | 2
      -               | ACTIVE_LOW    | L                   |

      Notes:
      1) Should print a warning about polarity inversion.
         Here it would be wise to avoid and define the gpio as
         ACTIVE_LOW.
      2) Should print a warning about polarity inversion
         because ACTIVE_LOW is overridden by spi-cs-high.
         Should be generally avoided and be replaced by
         spi-cs-high + ACTIVE_HIGH.
```

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
Link: https://github.com/openwrt/openwrt/pull/19845
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
This commit is contained in:
Shiji Yang
2025-08-24 20:57:18 +08:00
committed by Hauke Mehrtens
parent dd7087aa17
commit 2a709d108e
32 changed files with 34 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8062-wg2600hp3.dts
View File

@@ -249,7 +249,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8064-ad7200-c2600.dtsi
View File

@@ -89,7 +89,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8064-e8350-v1.dts
View File

@@ -140,7 +140,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
m25p80@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8064-fap-421e.dts
View File

@@ -212,7 +212,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "jedec,spi-nor";

4
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8064-onhub.dtsi
View File

@@ -410,7 +410,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash: flash@0 {
compatible = "jedec,spi-nor";
@@ -432,7 +432,7 @@
pinctrl-0 = <&spi6_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 57 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 57 GPIO_ACTIVE_LOW>;
dmas = <&adm_dma 8 0xb>,
<&adm_dma 7 0x14>;

2
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8064-unifi-ac-hd.dts
View File

@@ -105,7 +105,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "mx25u25635f", "jedec,spi-nor";

2
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8064-vr2600v.dts
View File

@@ -184,7 +184,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8064-wg2600hp.dts
View File

@@ -288,7 +288,7 @@ switch@10 {
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8064-wxr-2533dhp.dts
View File

@@ -346,7 +346,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8065-ac400i.dts
View File

@@ -166,7 +166,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
m25p80@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8065-nbg6817.dts
View File

@@ -219,7 +219,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
m25p80@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8065-rt4230w-rev6.dts
View File

@@ -134,7 +134,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "everspin,mr25h256";

2
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8065-tr4400-v2.dts
View File

@@ -136,7 +136,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "everspin,mr25h256";

2
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8068-ap3935.dts
View File

@@ -199,7 +199,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8068-ecw5410.dts
View File

@@ -183,7 +183,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
m25p80@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.12/arch/arm/boot/dts/qcom/qcom-ipq8068-ss-w2-ac2600.dts
View File

@@ -154,7 +154,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
w25q128@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8062-wg2600hp3.dts
View File

@@ -244,7 +244,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-ad7200-c2600.dtsi
View File

@@ -84,7 +84,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-e8350-v1.dts
View File

@@ -140,7 +140,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
m25p80@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-fap-421e.dts
View File

@@ -192,7 +192,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "jedec,spi-nor";

4
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-onhub.dtsi
View File

@@ -405,7 +405,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 0>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash: flash@0 {
compatible = "jedec,spi-nor";
@@ -427,7 +427,7 @@
pinctrl-0 = <&spi6_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 57 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 57 GPIO_ACTIVE_LOW>;
dmas = <&adm_dma 8 0xb>,
<&adm_dma 7 0x14>;

2
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-unifi-ac-hd.dts
View File

@@ -100,7 +100,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 0>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "mx25u25635f", "jedec,spi-nor";

2
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-vr2600v.dts
View File

@@ -179,7 +179,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-wg2600hp.dts
View File

@@ -288,7 +288,7 @@ switch@10 {
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8064-wxr-2533dhp.dts
View File

@@ -346,7 +346,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8065-ac400i.dts
View File

@@ -161,7 +161,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
m25p80@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8065-nbg6817.dts
View File

@@ -180,7 +180,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
m25p80@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8065-rt4230w-rev6.dts
View File

@@ -117,7 +117,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "everspin,mr25h256";

2
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8065-tr4400-v2.dts
View File

@@ -109,7 +109,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "everspin,mr25h256";

2
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8068-ap3935.dts
View File

@@ -194,7 +194,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
flash@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8068-ecw5410.dts
View File

@@ -178,7 +178,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
m25p80@0 {
compatible = "jedec,spi-nor";

2
target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8068-ss-w2-ac2600.dts
View File

@@ -149,7 +149,7 @@
pinctrl-0 = <&spi_pins>;
pinctrl-names = "default";
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_HIGH>;
cs-gpios = <&qcom_pinmux 20 GPIO_ACTIVE_LOW>;
w25q128@0 {
compatible = "jedec,spi-nor";