cleanup: Shift wpad reload from handler to instead occur in-place
We cannot afford to defer things to a handler when reconfiguring the network: we need to know as soon as possible when our playbook has gone up in flames and left a remote out-of-reach, so we can know what broke when we have to go and directly service the unit. I've hard-set the timeout here to 70 to handle the full one-minute DFS CAC timeout, but please, for the love of God, don't run mesh on UNII-2A. You do not want to be waiting that full minute for the device to come back.
This commit is contained in:
		
							parent
							
								
									b46bf38e84
								
							
						
					
					
						commit
						df4fd21984
					
				@ -16,8 +16,6 @@ templates:
 | 
			
		||||
      state: absent
 | 
			
		||||
    - name: wpad-wolfssl
 | 
			
		||||
      state: present
 | 
			
		||||
      notify:
 | 
			
		||||
        - Reload wpad
 | 
			
		||||
 | 
			
		||||
openwrt:
 | 
			
		||||
  hosts:
 | 
			
		||||
 | 
			
		||||
@ -1,7 +1,3 @@
 | 
			
		||||
- name: Reload wpad
 | 
			
		||||
  nohup:
 | 
			
		||||
    command: "wifi down; /etc/init.d/wpad restart; wifi up"
 | 
			
		||||
 | 
			
		||||
- name: Touch a file
 | 
			
		||||
  command:
 | 
			
		||||
    argv:
 | 
			
		||||
 | 
			
		||||
@ -4,6 +4,22 @@
 | 
			
		||||
    state: "{{ item.state }}"
 | 
			
		||||
  loop: "{{ packages.wpad | default([]) }}"
 | 
			
		||||
  notify: "{{ item.notify | default([]) }}"
 | 
			
		||||
  register: wpad_config
 | 
			
		||||
 | 
			
		||||
- name: Reload wpad
 | 
			
		||||
  nohup:
 | 
			
		||||
    command: "wifi down; /etc/init.d/wpad restart; wifi up"
 | 
			
		||||
    delay: 10
 | 
			
		||||
  when:
 | 
			
		||||
    - wpad_config.changed
 | 
			
		||||
 | 
			
		||||
- name: Wait for connection after netpkg reconfig
 | 
			
		||||
  wait_for_connection:
 | 
			
		||||
    timeout: 70
 | 
			
		||||
    delay: 5
 | 
			
		||||
  when:
 | 
			
		||||
    - wpad_config.changed
 | 
			
		||||
    - openwrt_wait_for_connection
 | 
			
		||||
 | 
			
		||||
- name: Install the correct ath10k packages
 | 
			
		||||
  opkg:
 | 
			
		||||
 | 
			
		||||
		Loading…
	
		Reference in New Issue
	
	Block a user